Cherry-pick #8653 to 6.x: Fix a race condition on add_host_metadata #8676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_host_metadata keeps a cache of the host data collected, this cache is now updated atomically. (cherry picked from commit 74b9c6c)
jsoriano
force-pushed
the
backport_8653_6.x
branch
from
5c40896 to
f32eba4
Compare
|
jenkins, test this again please |
sayden
reviewed
Oct 23, 2018
| @@ -40,7 +40,7 @@ https://github.com/elastic/beats/compare/v6.4.0...6.x[Check the HEAD diff] | |||
| - Deregister pipeline loader callback when inputsRunner is stopped. {pull}[7893][7893] | |||
| - Add backoff support to x-pack monitoring outputs. {issue}7966[7966] | |||
| - Removed execute permissions systemd unit file. {pull}7873[7873] | |||
| - Fix a race condition with the `add_host_metadata` and the event serialization. {pull}8223[8223] | |||
| - Fix a race condition with the `add_host_metadata` and the event serialization. {pull}8223[8223] {pull}8653[8653] | |||
There was a problem hiding this comment.
Double pull? What does it mean?
There was a problem hiding this comment.
This change is following another related fix (#8223), so both PRs are about the same issue.
There was a problem hiding this comment.
Thanks for the clarification 🙂
ruflin
approved these changes
Oct 23, 2018
sayden
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8653 to 6.x branch. Original message:
Not sure if adding a mutex at this level will be too blocking for events processing, I have also though on other options to reduce contention on reads:
Continues with #8223