Cherry-pick #7793 to 6.x: Fixes to metricbeat's KVM module #8706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improper error handling caused a panic when connection to libvirtd couldn't be stablished. Cleaned up error handling a little bit. Fixes elastic#7792 The default settings for the kvm module didn't work. Updated to connect to the unix socket by default, and provide a hint on how to setup access to libvirtd running on remote hosts. (cherry picked from commit 76d3949)
ph
approved these changes
Oct 23, 2018
ruflin
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #7793 to 6.x branch. Original message:
Some fixes to the kvm module:
host: [ "localhost" ]results in the module trying to create a network connection without schema. It will always fail with"dial: Unknown network ".For a default installation of
libvirtd, the only possible method is to use:host: [ "unix:///var/run/libvirt/libvirt-sock" ].Also some gidance is provided for setting up remote monitoring.