Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PowerShell to set the new beats service to delayed start #8720

Merged
merged 8 commits into from
Oct 24, 2018
Merged

Use PowerShell to set the new beats service to delayed start #8720

merged 8 commits into from
Oct 24, 2018

Conversation

rwaight
Copy link
Contributor

@rwaight rwaight commented Oct 23, 2018

Use PowerShell to execute sc config, so we can set the service to delayed start.

For issue: #8711

Use PowerShell to execute sc config, so we can set the service to delayed start.
@rwaight rwaight requested a review from andrewkroh October 23, 2018 23:12
@rwaight rwaight changed the title Set the new service to delayed start Use PowerShell to set the new beats service to delayed start Oct 23, 2018

# Attempt to set the service to delayed start using sc config.
Try {
$svcDelayed='config "{0}" start=delayed-auto' -f '{{.BeatName}}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work you directly put {{.Beatname}} instead of using "{0}"? Something like:

Start-Process -FilePath sc.exe -ArgumentList "config","{{.BeatName}}","start=delayed-auto"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll update the PR with that

Use PowerShell to execute sc config, so we can set the service to delayed start.
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script LGTM. Can you please add an entry to the CHANGELOG.asciidoc in the "Added" section under "affecting all beats".

Entry to the "Added" section under "affecting all beats".
@rwaight
Copy link
Contributor Author

rwaight commented Oct 24, 2018

Entry added to CHANGELOG.asciidoc

Entry to the "Added" section under "affecting all beats".
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Sync with elastic/beats master
Fix build for all OS after #8424 (#8717)
Change url.host.name to url.hostname (#8732)
@andrewkroh andrewkroh merged commit 2198af0 into elastic:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants