Fix kubernetes in-cluster configuration on IPv6 #8754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests in CI are not related |
|
This is great @jsoriano, did you push the fix upstream? It would be awesome to keep vendoring the main repo, we will probably want to upgrade to next releases in the future |
|
Just saw ericchiang/k8s#103 👍 merging this now, let's upgrade the dependency once they tag the next version including this fix |
exekias
approved these changes
Oct 26, 2018
jsoriano
added
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Oct 26, 2018
* Use patch to support ipv6 in k8s client (cherry picked from commit eb0ee32)
jsoriano
removed
the
needs_backport
|
just to close the loop on this - what container tag should I use with the fix in it when deploying? |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Oct 26, 2018
* Use patch to support ipv6 in k8s client (cherry picked from commit eb0ee32)
jsoriano
added a commit
that referenced
this pull request
Oct 26, 2018
|
@hhoover there is still no release including this change, in principle it will be included starting on 6.5. |
jsoriano
added a commit
that referenced
this pull request
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include patch for IPv6 in kubernetes client library (ericchiang/k8s#103),
already merged in master but not released yet.
Fixes #8749