-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore kibana.generated for all x-pack Beats #8917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
review
needs_backport
PR is waiting to be backported to other branches.
:Infra
labels
Nov 5, 2018
kvch
approved these changes
Nov 5, 2018
andrewkroh
reviewed
Nov 5, 2018
.gitignore
Outdated
@@ -9,6 +9,7 @@ | |||
/*/*.template*.json | |||
**/html_docs | |||
/*/_meta/kibana.generated | |||
/x-pack/*/_meta/kibana.generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking this might be better to put into https://github.com/elastic/beats/blob/master/x-pack/.gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
andrewkroh
approved these changes
Nov 5, 2018
ruflin
added
v6.6.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Nov 6, 2018
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Nov 6, 2018
(cherry picked from commit b14f42b)
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Nov 6, 2018
(cherry picked from commit b14f42b)
ruflin
added a commit
that referenced
this pull request
Nov 6, 2018
ruflin
added a commit
that referenced
this pull request
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.