kubernetes processor use correct os path separator #9205
Conversation
When appending a trailing slash to the log path directory, it needs to use the correct PathSeperator for the given OS. elastic#9196
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jsoriano
added
review
libbeat
containers
|
jenkins, test this |
| return "/var/lib/kubelet/pods/" | ||
| } | ||
|
|
||
| func ContainerLogsPath() string { |
There was a problem hiding this comment.
exported function ContainerLogsPath should have comment or be unexported
| return "/var/lib/docker/containers/" | ||
| } | ||
|
|
||
| func PodLogsPath() string { |
There was a problem hiding this comment.
exported function PodLogsPath should have comment or be unexported
| @@ -38,6 +40,7 @@ func init() { | |||
| } | |||
|
|
|||
| const LogPathMatcherName = "logs_path" | |||
| const PathSeparator = string(os.PathSeparator) | |||
There was a problem hiding this comment.
exported const PathSeparator should have comment or be unexported
zentron
force-pushed
the
kubernetes-path
branch
from
72e5fdc to
b176ab5
Compare
|
@eskibars thanks for the feedback. Have updated the tests to cover the new windows paths and made the other paths windows friendly |
|
jenkins, test this again |
|
Pinging @elastic/infrastructure |
|
@zentron Anyluck with the changelog entry? |
|
@exekias should we take this over? |
|
Sorry, i have been sidelined with other work and we have since moved to linux containers so this change is not such a high priority. |
When appending a trailing slash to the log path directory, it needs to use the correct PathSeperator for the given OS.
closes #9196