Add support for multi-core thread_id in filebeat postgresql module #9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
Filebeat
jsoriano
requested changes
Dec 11, 2018
CHANGELOG.asciidoc
Outdated
| @@ -83,6 +83,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha1...master[Check the HEAD d | |||
| - Added `detect_null_bytes` selector to detect null bytes from a io.reader. {pull}9210[9210] | |||
| - Added `syslog_host` variable to HAProxy module to allow syslog listener to bind to configured host. {pull}9366[9366] | |||
| - Added support on Traefik for Common Log Format and Combined Log Format mixed which is the default Traefik format {issue}8015[8015] {issue}6111[6111] {pull}8768[8768]. | |||
| - Add support for multi-core thread_id in postgresql module {issue}9156[9156] | |||
There was a problem hiding this comment.
Add also a reference to this PR please
| @@ -0,0 +1,19 @@ | |||
| 2018-11-17 13:14:01 CEST [12975-1] [unknown]@[unknown] LOG: incomplete startup packet | |||
There was a problem hiding this comment.
Add the expected file for this one please, I mentioned to remove the other one that was not related to this change.
There was a problem hiding this comment.
@jsoriano yes! I added it in the previous commit but the @timestamp failed on check job. That's why I tried to remove it to see if the check job will pass :-) I will definitely put it back in.
jsoriano
approved these changes
Dec 11, 2018
kaiyan-sheng
added
review
and removed
in progress
ruflin
approved these changes
Dec 12, 2018
|
@ruflin Sounds good! I just updated the PR description. Thanks! |
jsoriano
added
the
needs_backport
kaiyan-sheng
added a commit
that referenced
this pull request
Dec 17, 2018
…gresql module (#9482) (#9528) * Add support for multi-core thread_id in filebeat postgresql module (#9482) * Add support for multi-core thread_id in filebeat postgresql module * Change timestamp for test log file * update changelog and add multi-core.log-expected.json * Change timestamp in example log file * Update fields.go (cherry picked from commit 384b11b) * Run make update * Run test with 6.x Elasticsearch
kaiyan-sheng
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only support postgresql log looks like:
But this will fail when parsing postgresql log messages from multi-core machines which looks like:
This PR is to add optional core id after the original thread id to parse multi-core postgresql logs. Please see more details in #9156
closes #9156