Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog and uses match.Matcher interface #9504

Merged
merged 2 commits into from
Dec 12, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Dec 12, 2018

Add changelog and uses match.Matcher interface

Followup from #9099

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph
Copy link
Contributor Author

ph commented Dec 12, 2018

jenkins test this please

@ph
Copy link
Contributor Author

ph commented Dec 12, 2018

Errors are not related to this PR and darwin tests were killed.

@ph ph added the needs_backport PR is waiting to be backported to other branches. label Dec 12, 2018
@ph ph merged commit 9bf5fed into elastic:master Dec 12, 2018
@ph ph deleted the fix/blacklist-changelog branch December 12, 2018 19:04
ph added a commit to ph/beats that referenced this pull request Dec 12, 2018
* blacklist changelog

* Uses match.Matcher instead of *regexp.Matcher
@ph ph added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants