Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non index fields in default_field for Elasticsearch #9549

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Dec 14, 2018

We recently started to use fields with index: false. By default all fields are defined as keyword internally which meant these fields were also added to the list of default_fields for Elasticsearch. With this PR these fields are now excluded.

We recently started to use fields with `index: false`. By default all fields are defined as keyword internally which meant these fields were also added to the list of default_fields for Elasticsearch. With this PR these fields are now excluded.
@ruflin ruflin added review libbeat needs_backport PR is waiting to be backported to other branches. labels Dec 14, 2018
@ruflin ruflin requested a review from a team as a code owner December 14, 2018 11:43
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruflin
Copy link
Contributor Author

ruflin commented Dec 14, 2018

@elastic/apm-server You might be affected by this already in 6.x in case you use index: false.

@ruflin ruflin self-assigned this Dec 14, 2018
@ruflin ruflin merged commit 77c34fc into elastic:master Dec 14, 2018
@ruflin ruflin deleted the ignore-non-indexed-fields branch December 14, 2018 13:49
@ruflin ruflin added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 14, 2018
ruflin added a commit to ruflin/beats that referenced this pull request Dec 14, 2018
)

We recently started to use fields with `index: false`. By default all fields are defined as keyword internally which meant these fields were also added to the list of default_fields for Elasticsearch. With this PR these fields are now excluded.

(cherry picked from commit 77c34fc)
ruflin added a commit that referenced this pull request Dec 18, 2018
…9551)

We recently started to use fields with `index: false`. By default all fields are defined as keyword internally which meant these fields were also added to the list of default_fields for Elasticsearch. With this PR these fields are now excluded.

(cherry picked from commit 77c34fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants