Add setting to disable cgroup metrics per core #9589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
module
review
Metricbeat
|
Pinging @elastic/infrastructure |
houndci-bot
reviewed
Dec 17, 2018
jsoriano
force-pushed
the
cgroup-disable-cpu-per-core
branch
from
46c5829 to
032c886
Compare
jsoriano
force-pushed
the
cgroup-disable-cpu-per-core
branch
from
032c886 to
40616b6
Compare
ruflin
approved these changes
Dec 17, 2018
|
@jsoriano No need to make hound happy in this PR but we should probably do a quick follow up to clean it up? |
|
I made hound happy with my last push 🙂 All green, I am merging this. |
jsoriano
added
v6.6.0
and removed
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Dec 17, 2018
(cherry picked from commit 3185065)
jsoriano
added a commit
that referenced
this pull request
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cgroup CPU metrics collection per core can create loads of fields in hosts with lots of CPUs, and I am not sure if this is so useful. Add a flag to be able disable them by now on 6.6, and we can consider later to disable them by default on 7.0.
This is the cgroups counterpart for what we already did for docker in #9194.
Fix #9326