Update to golang 1.11.4 #9627
Merged
Update to golang 1.11.4 #9627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Dec 18, 2018
There was a problem hiding this comment.
Does this also need update in https://github.com/elastic/golang-crossbuild ?
CHANGELOG.asciidoc
Outdated
| @@ -56,6 +55,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha1...master[Check the HEAD d | |||
| - When collecting swap metrics for beats telemetry or system metricbeat module handle cases of free swap being bigger than total swap by assuming no swap is being used. {issue}6271[6271] {pull}9383[9383] | |||
| - Adding logging traces at debug level when the pipeline client receives the following events: onFilteredOut, onDroppedOnPublish. {pull}9016[9016] | |||
| - Ignore non index fields in default_field for Elasticsearch. {pull}9549[9549] | |||
| - Update to Golang 1.11.3. {pull}9560[9560] | |||
There was a problem hiding this comment.
I think the first one becomes obsolete?
There was a problem hiding this comment.
Well, a changelog is a trace of what was done so I am not sure I would remove that.
There was a problem hiding this comment.
I would argue this changelog here is for the users and it only matters what happened between releases. If we introduce a bug and fix it before it is released, we also don't list it here.
ph
commented
Dec 19, 2018
There was a problem hiding this comment.
@ruflin crossbuild update was done in elastic/golang-crossbuild#11
CHANGELOG.asciidoc
Outdated
| @@ -56,6 +55,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha1...master[Check the HEAD d | |||
| - When collecting swap metrics for beats telemetry or system metricbeat module handle cases of free swap being bigger than total swap by assuming no swap is being used. {issue}6271[6271] {pull}9383[9383] | |||
| - Adding logging traces at debug level when the pipeline client receives the following events: onFilteredOut, onDroppedOnPublish. {pull}9016[9016] | |||
| - Ignore non index fields in default_field for Elasticsearch. {pull}9549[9549] | |||
| - Update to Golang 1.11.3. {pull}9560[9560] | |||
``` go1.11.4 (released 2018/12/14) includes fixes to cgo, the compiler, linker, runtime, documentation, go command, and the net/http and go/types packages. It includes a fix to a bug introduced in Go 1.11.3 that broke go get for import path patterns containing "...". See the Go 1.11.4 milestone on our issue tracker for details. ``` more details at : https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+label%3ACherryPickApproved
ph
force-pushed
the
fix/golang-1.11.4
branch
from
3171423 to
aadcdb6
Compare
|
Packetbeat CI issue is not related to this PR. |
ruflin
approved these changes
Dec 19, 2018
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
``` go1.11.4 (released 2018/12/14) includes fixes to cgo, the compiler, linker, runtime, documentation, go command, and the net/http and go/types packages. It includes a fix to a bug introduced in Go 1.11.3 that broke go get for import path patterns containing "...". See the Go 1.11.4 milestone on our issue tracker for details. ``` more details at : https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+label%3ACherryPickApproved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more details at : https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+label%3ACherryPickApproved