Replace all grok :int coercions with :long coercions #9638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
added
in progress
webmat
changed the title
webmat
added
review
and removed
in progress
|
I've kicked the |
andrewvc
approved these changes
Dec 18, 2018
ruflin
approved these changes
Dec 19, 2018
|
@andrewvc Haha yeah I know it looks strange 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the section "Modules already merged" of #9598
Note that the strategy here is to coerce absolutely all integers with
:long, even if they have no chance to overflow a signed int. Trying to keep the approach simple in the future.The only place where it may make sense to keep
:intis actually for the status codes, which stop in the 500s. The port and PIDs will overflow the signed int.