Support different timestamp format in postgresql module #9650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
module
review
Filebeat
ruflin
approved these changes
Dec 19, 2018
jsoriano
reviewed
Dec 19, 2018
|
+1 to backporting it |
jsoriano
approved these changes
Dec 19, 2018
ruflin
approved these changes
Dec 20, 2018
|
@kaiyan-sheng This PR accidentially broke CI as since the approval it seems some ECS changes went in on the postgres side (see fix here): #9777 Make sure in the backport that the data structure is correct (it should be). I'm suprised you didn't have a conflict. As CI was green and no conflicts, you couldn't know 👍 |
kaiyan-sheng
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current postgresql module, if the log timestamp does not match
yyyy-MM-dd HH:mm:ss.SSS, then instead of using the timestamp from the log, it uses current timestamp. To fix this, I think addingyyyy-MM-dd HH:mm:ssinto the timestamp/date formats list should work. Now postgresql module will know both timestamps are expected.closes #9494