Replace missing field names from status Metricset in MongoDB Dashboard #9795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayden
changed the title
ruflin
reviewed
Dec 27, 2018
| @@ -37,7 +37,7 @@ | |||
| "enabled": true, | |||
| "id": "2", | |||
| "params": { | |||
| "field": "metricset.host", | |||
| "field": "host.name", | |||
There was a problem hiding this comment.
metricset.host and host.name are not the same thing. host.name is then name from the host on which the beat runs, metricset.host is what address of the service it connects to.
These fields should not have changed in the PR your linked. Same below.
There was a problem hiding this comment.
Ok, I have reverted both ocurrences of host.name to their original values metricset.host
ruflin
added
the
needs_backport
sayden
force-pushed
the
bugfix/mb/mongodb-dashboard
branch
from
b1b7eac to
c2eba63
Compare
sayden
force-pushed
the
bugfix/mb/mongodb-dashboard
branch
from
c2eba63 to
3b4da99
Compare
ruflin
approved these changes
Dec 27, 2018
|
Yes, of course. That's how I realized that I'll wait for your answer before merging. |
|
@sayden All good. Please merge and backport. |
sayden
added a commit
to sayden/beats
that referenced
this pull request
Jan 8, 2019
elastic#9795) (cherry picked from commit fba0680)
sayden
added
v6.7.0
and removed
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #9715 it seems that some field names within the MongoDB dashboard were incorrect.
It seems that this commit changed the field names 5544838 5 months ago.
In this PR, the correct field names are set. I'm not very experienced with Kibana so I have just modified current dashboard JSON file instead of replacing it with the exported one using this method.
Working in Kibana 6.5.4