Add migration.enabled config option #9805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 27, 2018
ruflin
force-pushed
the
introduce-migration
branch
from
e6be910 to
5a94aa8
Compare
ruflin
commented
Jan 10, 2019
| @@ -63,7 +63,7 @@ import ( | |||
| svc "github.com/elastic/beats/libbeat/service" | |||
| "github.com/elastic/beats/libbeat/template" | |||
| "github.com/elastic/beats/libbeat/version" | |||
| "github.com/elastic/go-sysinfo" | |||
| sysinfo "github.com/elastic/go-sysinfo" | |||
There was a problem hiding this comment.
Seems like my idea / goimports did this automatically. Interesting.
|
Trying to add support to enable / disable aliases for the Kibana index pattern I stumbled over the following issue: #10013 Also opened elastic/kibana#28570 to get better support in Kibana. |
ruflin
force-pushed
the
introduce-migration
branch
from
5a94aa8 to
141053a
Compare
ruflin
force-pushed
the
introduce-migration
branch
from
141053a to
6c0d37b
Compare
ruflin
changed the title
|
This PR will only address migration aliases for the Elasticsearch index template. A follow up PR will be created to also enable / disable it in Kibana index pattern after #10075 is done. |
ruflin
force-pushed
the
introduce-migration
branch
2 times, most recently
from
84ea2bc to
6c07d6d
Compare
|
This is ready for review. |
ruflin
force-pushed
the
introduce-migration
branch
from
6c07d6d to
46017b9
Compare
jsoriano
requested changes
Jan 18, 2019
jsoriano
approved these changes
Jan 18, 2019
kaiyan-sheng
approved these changes
Jan 18, 2019
The migration.enabled config option is off by default. Enabling it will add all the alias fields which are used for making Beats 7.x data compatible with 6.x data for queries and dashboards. A user that upgrades can either set `migration.enabled: true` in the config file or run `-E migration.enabled=true` on the command line to also have the migration aliases in the Elasticsearch index template. Further changes: * Add system test to check the generated template * Fix autodiscovery tests. Were broken as probably the removal of the aliases by default did not work here as it relied on apache2.
ruflin
force-pushed
the
introduce-migration
branch
from
fb1a3a5 to
dd782d1
Compare
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
The migration.enabled config option is off by default. Enabling it will add all the alias fields which are used for making Beats 7.x data compatible with 6.x data for queries and dashboards. A user that upgrades can either set `migration.enabled: true` in the config file or run `-E migration.enabled=true` on the command line to also have the migration aliases in the Elasticsearch index template. Further changes: * Add system test to check the generated template * Fix autodiscovery tests. Were broken as probably the removal of the aliases by default did not work here as it relied on apache2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration.enabled config option is off by default. Enabling it will add all the alias fields which are used for making Beats 7.x data compatible with 6.x data for queries and dashboards.
A user that upgrades can either set
migration.enabled: truein the config file or run-E migration.enabled=trueon the command line to also have the migration aliases in the Elasticsearch index template.Further changes: