Fix config appender registration #9873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
needs_backport
Autodiscover config wasn't regsistered, this change updates the code, adds integration tests and makes sure that the appender is correctly registered and working.
exekias
force-pushed
the
fix-config-appender
branch
from
f0d8229 to
ba2e002
Compare
|
Unfortunately metricbeat CI failed on some appender related tests: |
urso
reviewed
Jan 4, 2019
| @@ -20,6 +20,8 @@ package config | |||
| import ( | |||
| "fmt" | |||
|
|
|||
| "github.com/pkg/errors" | |||
There was a problem hiding this comment.
Did you mean "errors" or "github.com/pkg/errors". Just asking as I'm seeing this wrong import a lot recently.
There was a problem hiding this comment.
https://github.com/pkg/errors is the one that gives me errors.Wrap, I think this is correct?
|
good catch! and thank you for the review, I just pushed 4426dae as testing config was wrong |
urso
approved these changes
Jan 9, 2019
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Jan 9, 2019
exekias
added a commit
that referenced
this pull request
Jan 9, 2019
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jan 9, 2019
* Fix config appender registration Autodiscover config wasn't regsistered, this change updates the code, adds integration tests and makes sure that the appender is correctly registered and working. * Add missing appender type in tests (cherry picked from commit 370ecd4)
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jan 9, 2019
(cherry picked from commit d036f26)
exekias
removed
the
needs_backport
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jan 9, 2019
* Fix config appender registration Autodiscover config wasn't regsistered, this change updates the code, adds integration tests and makes sure that the appender is correctly registered and working. * Add missing appender type in tests (cherry picked from commit 370ecd4)
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jan 9, 2019
(cherry picked from commit d036f26)
|
Please backport to 6.6 branch as well. |
exekias
added a commit
that referenced
this pull request
Jan 10, 2019
* Fix config appender registration (#9873) * Fix config appender registration Autodiscover config wasn't regsistered, this change updates the code, adds integration tests and makes sure that the appender is correctly registered and working. * Add missing appender type in tests (cherry picked from commit 370ecd4) * Add changelog for #9873 (#9961) (cherry picked from commit d036f26)
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jan 18, 2019
* Fix config appender registration Autodiscover config wasn't regsistered, this change updates the code, adds integration tests and makes sure that the appender is correctly registered and working. * Add missing appender type in tests (cherry picked from commit 370ecd4)
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jan 18, 2019
(cherry picked from commit d036f26)
exekias
added a commit
that referenced
this pull request
Jan 18, 2019
* Fix config appender registration (#9873) * Fix config appender registration Autodiscover config wasn't regsistered, this change updates the code, adds integration tests and makes sure that the appender is correctly registered and working. * Add missing appender type in tests (cherry picked from commit 370ecd4) * Add changelog for #9873 (#9961) (cherry picked from commit d036f26) * make update
exekias
added a commit
that referenced
this pull request
Jan 23, 2019
* Fix config appender registration (#9873) * Fix config appender registration Autodiscover config wasn't regsistered, this change updates the code, adds integration tests and makes sure that the appender is correctly registered and working. * Add missing appender type in tests (cherry picked from commit 370ecd4) * Add changelog for #9873 (#9961) (cherry picked from commit d036f26)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#10181) * Fix config appender registration (elastic#9873) * Fix config appender registration Autodiscover config wasn't regsistered, this change updates the code, adds integration tests and makes sure that the appender is correctly registered and working. * Add missing appender type in tests (cherry picked from commit 662082a) * Add changelog for elastic#9873 (elastic#9961) (cherry picked from commit 23bddef)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#9966) * Fix config appender registration (elastic#9873) * Fix config appender registration Autodiscover config wasn't regsistered, this change updates the code, adds integration tests and makes sure that the appender is correctly registered and working. * Add missing appender type in tests (cherry picked from commit 662082a) * Add changelog for elastic#9873 (elastic#9961) (cherry picked from commit 23bddef) * make update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autodiscover config wasn't regsistered, this change updates the code,
adds integration tests and makes sure that the appender is correctly
registered and working.
closes #9817