Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark redis/logstash port settings as deprecated #9915

Merged
merged 4 commits into from
Jan 23, 2019
Merged

Conversation

urso
Copy link

@urso urso commented Jan 7, 2019

The port settigns for redis/logstash have been marked as deprecated since 5.0. This change will print a deprecation warning if the settings are used. We will remove the setting in 7.0.

@urso urso requested a review from a team January 7, 2019 03:06
@kaiyan-sheng
Copy link
Contributor

Seem like mage fmt update is needed for filebeat.

@urso urso added the needs_backport PR is waiting to be backported to other branches. label Jan 16, 2019
@urso
Copy link
Author

urso commented Jan 22, 2019

Jenkins, test this

@urso urso merged commit ccfb332 into elastic:6.x Jan 23, 2019
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Jan 31, 2019
@urso urso deleted the deprecate-ports branch February 19, 2019 18:39
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
The port settigns for redis/logstash have been marked as deprecated since 5.0. This change will print a deprecation warning if the settings are used. We will remove the setting in 7.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants