Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pause annotation #2594

Closed
pebrc opened this issue Feb 21, 2020 · 3 comments · Fixed by #2783
Closed

Rename pause annotation #2594

pebrc opened this issue Feb 21, 2020 · 3 comments · Fixed by #2783
Assignees
Labels
discuss We need to figure this out >enhancement Enhancement of existing functionality v1.1.0

Comments

@pebrc
Copy link
Collaborator

pebrc commented Feb 21, 2020

common.k8s.elastic.co/pause: "true" is somewhat misleading as it might indicate to users that it pauses the managed containers i.e. the Elasticsearch processes which is of course not the case.

  • Let's find a better name. A few ideas:
    • common.k8s.elastic.co/suspend-reconciliation (or pause-reconciliation)
    • common.k8s.elastic.co/freeze (or freeze-config)
    • common.k8s.elastic.co/cordon (maybe problematic as you can cordon k8s nodes as well)
    • common.k8s.elastic.co/lock-config
  • Rename and document the new annotation
@pebrc pebrc added >enhancement Enhancement of existing functionality v1.1.0 discuss We need to figure this out labels Feb 21, 2020
@thbkrkr
Copy link
Contributor

thbkrkr commented Feb 21, 2020

Another proposal: common.k8s.elastic.co/managed.

Influenced by Google Config Sync which has a similar mechanism with an annotation to start and stop managing an object without deleting it.

@charith-elastic
Copy link
Contributor

+1 for managed but maybe like eck.k8s.elastic.co/managed to make it explicit that they are opting out of ECK management.

Alternatively, eck.k8s.elastic.co/ignore might be simpler.

@thbkrkr
Copy link
Contributor

thbkrkr commented Feb 21, 2020

+1 for eck.k8s.elastic.co/.* instead of common.k8s.elastic.co/.* if we can :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss We need to figure this out >enhancement Enhancement of existing functionality v1.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants