Rename pause annotation #2783
Rename pause annotation #2783
Conversation
New eck.k8s.elastic.co/managed annotation, with inverted boolean semantics: false stops reconciliation. True is implied if not specified by the user. Legacy pause annotation is still supported for existing deployments.
Co-Authored-By: Charith Ellawala <52399125+charith-elastic@users.noreply.github.com>
pkg/controller/common/unmanaged.go
Outdated
| managed, newExists := parse(ManagedAnnotation, true) | ||
| paused, legacyExists := parse(LegacyPauseAnnoation, false) | ||
| if legacyExists && !newExists { | ||
| log.V(-1).Info(fmt.Sprintf("Using legacy annotation %s. Please consider moving to %s", LegacyPauseAnnoation, ManagedAnnotation), "namespace", meta.Namespace, "name", meta.Name) |
There was a problem hiding this comment.
We currently don't use the -1 level for anything else that I saw. I'm a little bit skeptical about starting to use it for this? I'm open to it but could use some persuading. My gut feeling is that no one reads warning messages and that they should be errors or info messages.
There was a problem hiding this comment.
Good point will change back to info.
|
This should have the |
|
It’s not a breaking change imo because we still support the old annotation. |
Yeah that makes sense, but I wonder what else we put it under so that it can be found in release notes or closed PRs. Is it time maybe to add support for a |
pebrc
added
>enhancement
I add the |
New
eck.k8s.elastic.co/managedannotation, with inverted booleansemantics: false stops reconciliation. True is implied if not
specified by the user.
Legacy pause annotation is still supported for existing deployments.
Fixes #2594