Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor webhook name flag #3621

Closed
charith-elastic opened this issue Aug 13, 2020 · 0 comments · Fixed by #3631
Closed

Refactor webhook name flag #3621

charith-elastic opened this issue Aug 13, 2020 · 0 comments · Fixed by #3631
Labels
>refactoring

Comments

@charith-elastic
Copy link
Contributor

A few issues came to light while investigating CR comments from #3570

  • The flag can be shortened from webhook-configuration-name to webhook-name
  • Variables and struct members used to support the feature are too Java-esque and can be simplified
  • Sorting order is not preserved in the documentation and the flag list
  • Flag description doesn't need to include the default value as Cobra already prints it out
  • Manifest generator hasn't been updated to make use of the flag

These changes are trivial but should be done after merging #3570 to avoid a merge conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor webhook name configuration charith-elastic/cloud-on-k8s
1 participant
@charith-elastic