New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor webhook name configuration #3631

Merged

charith-elastic merged 1 commit into elastic:master from charith-elastic:refactor/webhook-configuration-flag

Aug 14, 2020

Contributor

charith-elastic commented Aug 14, 2020

Minor refactoring to address the following:

The flag can be shortened from webhook-configuration-name to webhook-name
Variables and struct members used to support the feature are too Java-esque and can be simplified
Sorting order is not preserved in the documentation and the flag list
Flag description doesn't need to include the default value as Cobra already prints it out
Manifest generator hasn't been updated to make use of the flag

Fixes #3621


          Refactor webhook name configuration

964f830

charith-elastic added >refactoring v1.3.0 labels

anyasabo approved these changes

View reviewed changes

charith-elastic merged commit 48a2564 into elastic:master

charith-elastic deleted the refactor/webhook-configuration-flag branch

August 14, 2020 15:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>refactoring v1.3.0