Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename nodeCount to something simpler #682

Closed
sebgl opened this issue Apr 25, 2019 · 2 comments
Closed

Rename nodeCount to something simpler #682

sebgl opened this issue Apr 25, 2019 · 2 comments
Labels
justdoit Continuous improvement not related to a specific feature

Comments

@sebgl
Copy link
Contributor

sebgl commented Apr 25, 2019

Either "replicas" or "count" or "chicken"?
@sebgl sebgl added the justdoit Continuous improvement not related to a specific feature label Apr 25, 2019
@sebgl sebgl added this to the Alpha milestone Apr 25, 2019
@sebgl sebgl changed the title Rename nodeCount to something cleaner Rename nodeCount to something simpler Apr 25, 2019
@pebrc
Copy link
Collaborator

pebrc commented May 4, 2019 •
edited
Loading

We decided to hold of on this for now, mainly because the proposed alternatives did not seem convincing enough:

  • replicas has the potential to be confused with shard level replicas in Elasticsearch (even though there is a strong precedent for this name in the k8s ecosystem)
  • count did not seem superior to nodeCount to warrant a rename

Revisit later when better alternatives emerge or consensus can be found on one of the proposals.

@pebrc pebrc removed this from the Alpha milestone May 10, 2019
@nkvoll
Copy link
Member

nkvoll commented May 20, 2019

@pebrc safe to close?

@pebrc pebrc closed this as completed May 20, 2019
@sebgl sebgl mentioned this issue Aug 9, 2019
Closed
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/cloud-on-k8s that referenced this issue May 22, 2023
@lltx
Merge pull request elastic#682 from jiangying000/master
22d33eb 
remove preceding space at filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
justdoit Continuous improvement not related to a specific feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkvoll @pebrc @sebgl