Move prepare-fs script to scripts configmap #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-kow
requested review from
artemnikitin,
barkbay,
idanmo,
nkvoll,
pebrc,
sebgl and
thbkrkr
as code owners
david-kow
force-pushed
the
move_scripts_to_configmap
branch
from
a85f50b to
999ad1d
Compare
To copy plugin files between init and es volumes we iterated PrepareFsSharedVolumes variable. Issue was that this variable also included data and logs volumes which we don't need to copy from. This commit introduces new variable for plugin volumes only as PrepareFsSharedVolumes is used for other purposes too.
pebrc
reviewed
Jun 14, 2019
operators/pkg/controller/elasticsearch/settings/merged_config.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script gets generated early in Reconcile and put in scripts configMap. The script is effectively static, so linkedFiles reside now closer to the script generation instead of being passed down. Mount paths for data and logs volumes shared between init and ES containers were moved to settings to remove dependency on initcontainer and avoid circular dependency after moving linkedFiles to initcontainer.
Closes #932, before/after: