Fix scripts invocation #1077
Merged
Fix scripts invocation #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three issues being fixed here: 1. 'bash -c string' reads commands from string and interprets them. There is no call to execve as there is no file. This means that shebang gets ignored as a comment. 2. shebang contains path to env, bash and bash_arguments, but handling of the arguments differ. On OSX it will pass arguments correctly (and run '/usr/bin/env bash -eu'), but on centos it will try to call '/usr/bin/env "bash bash_arguments"' which will fail. 3. '#!' have to be first two characters. Shebang is kept in the script body, so its runnable even if invoked differently. Current invocation of the script is changed to go via env directly.
david-kow
requested review from
artemnikitin,
barkbay,
idanmo,
nkvoll,
pebrc and
thbkrkr
as code owners
thbkrkr
approved these changes
Jun 14, 2019
pebrc
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three issues being fixed here:
Shebang is kept in the script body, so its runnable even if invoked differently. Current invocation of the script is changed to go via env directly.