Update operator information #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may be seen as private.
thbkrkr
changed the title
thbkrkr
force-pushed
the
remove-ns-from-operator-info
branch
from
6992d97 to
9ded81d
Compare
pebrc
reviewed
Jun 26, 2019
artemnikitin
approved these changes
Jun 30, 2019
sebgl
reviewed
Jul 1, 2019
There was a problem hiding this comment.
LGTM implementation-wise. I'm a bit concerned about the general purpose behind this.
I'm not sure what CustomOperatorNamespace brings us. Why do we care? We do have to support deploying the operator in a custom namespace anyway, it's not like we would change things if we noticed most people use the default namespace?
Would listing the operator roles instead (global, namespace, all) be more interesting?
sebgl
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit: