Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana HTTP certificates #1148

Merged
merged 15 commits into from
Jul 2, 2019
Merged

Kibana HTTP certificates #1148

merged 15 commits into from
Jul 2, 2019

Conversation

pebrc
Copy link
Collaborator

@pebrc pebrc commented Jun 26, 2019 •
edited
Loading

Fixes #90

  • refactored elasticsearch/http package to be reused from Kibana & Elasticsearch
  • configure TLS in Kibana
  • validate TLS disabled flag in Elasticsearch
  • parameterize CN in HTTP certs (Kibana/Elasticsearch)
  • e2e tests where only updated I was hesitant to make larger changes there as @thbkrkr refactoring is coming soon

@pebrc pebrc marked this pull request as ready for review June 27, 2019 17:00
@pebrc pebrc requested review from sebgl, thbkrkr and nkvoll July 1, 2019 13:31
@pebrc
Copy link
Collaborator Author

pebrc commented Jul 2, 2019

@thbkrkr I have fixed the issues you found could you take another look?

sebgl
sebgl approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Nice to see how we can reuse ES TLS stuff!

operators/pkg/apis/common/v1alpha1/common.go
// Enabled returns true when TLS is enabled based on this option struct.
func (tls TLSOptions) Enabled() bool {
selfSigned := tls.SelfSignedCertificate
return selfSigned == nil || !selfSigned.Disabled || tls.Certificate.SecretName != ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks tricky enough to deserve a unit test maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

thbkrkr
thbkrkr approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pebrc pebrc merged commit 09404df into elastic:master Jul 2, 2019
@barkbay barkbay mentioned this pull request Jul 5, 2019
Closed
@pebrc pebrc added >feature Adds or discusses adding a feature to the product v0.9.0 labels Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebgl sebgl sebgl approved these changes

@thbkrkr thbkrkr thbkrkr approved these changes

@nkvoll nkvoll Awaiting requested review from nkvoll

Assignees
No one assigned
Labels
>feature Adds or discusses adding a feature to the product v0.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security: Kibana HTTP-side certificates
3 participants
@pebrc @thbkrkr @sebgl