APM configuration #1181
Merged
APM configuration #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
reviewed
Jul 3, 2019
| // ElasticsearchAuth contains auth config for Kibana to use with an Elasticsearch cluster | ||
| type ElasticsearchAuth struct { | ||
| // Inline is auth provided as plaintext inline credentials. | ||
| Inline *ElasticsearchInlineAuth `json:"inline,omitempty"` |
There was a problem hiding this comment.
Do we still need inline auth?
There was a problem hiding this comment.
👍
I would like to do it in an other PR, this one is already quite big and removing ElasticsearchInlineAuth has some implications in the Kibana tests.
operators/pkg/controller/common/association/association_test.go
Outdated
Show resolved
Hide resolved
operators/test/e2e/apm/checks_k8s.go
Outdated
| @@ -35,7 +35,7 @@ func CheckApmServerDeployment(stack Builder, k *helpers.K8sHelper) helpers.TestS | |||
| var dep appsv1.Deployment | |||
| err := k.Client.Get(types.NamespacedName{ | |||
| Namespace: params.Namespace, | |||
| Name: stack.ApmServer.Name + "-apm-server", | |||
| Name: stack.ApmServer.Name + "-apm", | |||
There was a problem hiding this comment.
Any particular reason for moving away from apm-server?
There was a problem hiding this comment.
At first it was not intentional, I did it when I was working on the naming. I thought it was not so bad since "-server" does not bring much value. But since the name of the container is apm-server I'm ok to keep it 😃
This was referenced Jul 5, 2019
Closed
pebrc
approved these changes
Jul 5, 2019
sebgl
added a commit
that referenced
this pull request
Jul 12, 2019
* Support for APM server configuration (#1181) * Add a config section to the APM server configuration * APM: Add support for keystore * Factorize ElasticsearchAuthSettings * Update dev setup doc + fix GKE bootstrap script (#1203) * Update dev setup doc + fix GKE bootstrap script * Update wording of container registry authentication * Ensure disks removal after removing cluster in GKE (#1163) * Update gke-cluster.sh * Implement cleanup for unused disks in GCP * Update Makefile * Update CI jobs to do proper cleanup * Normalize the raw config when creating canonical configs (#1208) This aims at counteracting the difference between JSON centric serialization and the use of YAML as the serialization format in canonical config. If not normalizing numeric values like 1 will differ when comparing configs as JSON deserializes integer numbers to float64 and YAML to uint64. * Homogenize logs (#1168) * Don't run tests if only docs are changed (#1216) * Update Jenkinsfile * Simplify notOnlyDocs() * Update Jenkinsfile * Push snapshot ECK release on successful PR build (#1184) * Update makefile's to support snapshots * Add snapshot releases to Jenkins pipelines * Cleanup * Rename RELEASE to USE_ELASTIC_DOCKER_REGISTRY * Update Jenkinsfile * Add a note on EKS inbound traffic & validating webhook (#1211) EKS users must explicitly enable communication from the k8s control plane and nodes port 443 in order for the control plane to reach the validating webhook. Should help with #896. * Update PodSpec with Hostname from PVC when re-using (#1204) * Bind the Debug HTTP server to localhost by default (#1220) * Run e2e tests against custom Docker image (#1135) * Add implementation * Update makefile's * Update Makefile * Rename Jenkisnfile * Fix review comments * Update e2e-custom.yml * Update e2e-custom.yml * Return deploy-all-in-one to normal * Delete GKE cluster only if changes not in docs (#1223) * Add operator version to resources (#1224) * Warn if unsupported distribution (#1228) The operator only works with the official ES distributions to enable the security available with the basic (free), gold and platinum licenses in order to ensure that all clusters launched are secured by default. A check is done in the prepare-fs script by looking at the existence of the Elastic License. If not present, the script exit with a custom exit code. Then the ES reconcilation loop sends an event of type warning if it detects that a prepare-fs init container terminated with this exit code. * Document Elasticsearch update strategy change budget & groups (#1210) Add documentation for the `updateStrategy` section of the Elasticsearch spec. It documents how (and why) `changeBudget` and `groups` are used by ECK, and how both settings can be specified by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This PR do not (new issues will be open):
Fix #53