Remove APM server defaults and allow standalone operation #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pebrc
commented
Jul 12, 2019
pebrc
commented
- removes APM server config defaults (feedback from the APM team)
- allows standalone operation without Elasticsearch output (e.g. using console, kafka, logstash etc. output)
- why combine the two changes in one PR? Because we were hard-coding Elasticsearch output in the config defaults
- adds an e2e test for standalone operation
- why no unit test? because reconcile loop is still hard to test
thbkrkr
reviewed
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.