Remove support for full cluster restart with pod reuse

docs/design/0009-pod-reuse-es-restart.md

@@ -1,6 +1,6 @@
 # Reusing pods by restarting the ES process with a new configuration
 
-* Status: proposed
+* Status: rejected (implementation removed) in July 2019, in favor of moving towards the StatefulSet way of doing rolling restarts. The process-manager is also out of the picture. We don't reuse pods. Main benefits are code and architecture simplicity as well as respecting k8s standards.
 * Deciders: cloud-on-k8s team
 * Date: 2019-03-20
 

operators/pkg/controller/elasticsearch/driver/default.go

@@ -34,7 +34,6 @@ import (
 	"github.com/elastic/cloud-on-k8s/operators/pkg/controller/elasticsearch/pod"
 	"github.com/elastic/cloud-on-k8s/operators/pkg/controller/elasticsearch/pvc"
 	"github.com/elastic/cloud-on-k8s/operators/pkg/controller/elasticsearch/reconcile"
-	"github.com/elastic/cloud-on-k8s/operators/pkg/controller/elasticsearch/restart"
 	"github.com/elastic/cloud-on-k8s/operators/pkg/controller/elasticsearch/services"
 	"github.com/elastic/cloud-on-k8s/operators/pkg/controller/elasticsearch/settings"
 	"github.com/elastic/cloud-on-k8s/operators/pkg/controller/elasticsearch/user"
@@ -239,25 +238,6 @@ func (d *defaultDriver) Reconcile(
 		"es_name", es.Name,
 	)
 
-	// restart ES processes that need to be restarted before going on with other changes
-	done, err := restart.HandleESRestarts(
-		restart.RestartContext{
-			Cluster:        es,
-			EventsRecorder: reconcileState.Recorder,
-			K8sClient:      d.Client,
-			Changes:        *changes,
-			Dialer:         d.Dialer,
-			EsClient:       esClient,
-		},
-	)
-	if err != nil {
-		return results.WithError(err)
-	}
-	if !done {
-		log.V(1).Info("Pods restart is not over yet, re-queueing.", "namespace", es.Namespace, "es_name", es.Name)
-		return results.WithResult(defaultRequeue)
-	}
-
 	// figure out what changes we can perform right now
 	performableChanges, err := mutation.CalculatePerformableChanges(es.Spec.UpdateStrategy, *changes, podsState)
 	if err != nil {