Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove process manager #1249

Merged
merged 4 commits into from
Jul 16, 2019
Merged

Remove process manager #1249

merged 4 commits into from
Jul 16, 2019

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Jul 16, 2019

Resolves #1199.

@barkbay
Copy link
Contributor

barkbay commented Jul 16, 2019

Any reason to keep controller/elasticsearch/processmanager ? https://github.com/elastic/cloud-on-k8s/tree/f6ee59776ae07a82ca044476692e23a8654f3c95/operators/pkg/controller/elasticsearch/processmanager

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jul 16, 2019

Any reason to keep controller/elasticsearch/processmanager ?

No. I rebased a little fast ...

@thbkrkr thbkrkr requested a review from barkbay July 16, 2019 13:32
@thbkrkr thbkrkr added the v0.9.0 label Jul 16, 2019
barkbay
barkbay approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr thbkrkr merged commit 4029bfd into elastic:master Jul 16, 2019
thbkrkr added a commit to thbkrkr/cloud-on-k8s that referenced this pull request Jul 16, 2019
@thbkrkr
Remove process manager (elastic#1249)
3444d04 
* Remove the process manager
* Update ADR status to rejected
* Remove operator image var and flag
@thbkrkr thbkrkr mentioned this pull request Jul 16, 2019
Closed
@thbkrkr thbkrkr deleted the remove-process-manager branch July 16, 2019 15:47
@sebgl sebgl mentioned this pull request Jul 17, 2019
Closed
artemnikitin pushed a commit to artemnikitin/cloud-on-k8s that referenced this pull request Jul 17, 2019
@thbkrkr
Remove process manager (elastic#1249) (elastic#1260)
f2b5288 
* Remove the process manager
* Update ADR status to rejected
* Remove operator image var and flag
@pebrc pebrc added the >enhancement Enhancement of existing functionality label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barkbay barkbay barkbay approved these changes

Assignees
No one assigned
Labels
>enhancement Enhancement of existing functionality v0.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the process manager
3 participants
@thbkrkr @barkbay @pebrc