[Backport] Remove process manager (#1249)

docs/design/0011-process-manager.md

@@ -1,6 +1,10 @@
 # 11. Process manager for keystore update and Elasticsearch restart
 
-* Status: proposed 
+* Status: rejected (implementation removed) in July 2019. The keystore updater is moved into an init container to adopt the same 
+pattern used for Kibana and APM server. With the move towards the StatefulSet way of doing rolling restarts, we no longer need a
+process manager to perform Elasticsearch cluster restart. The zombie reaping problem only exists when another process is started
+in the container (e.g. kubectl exec) and should probably be handled in the official images.
+Main benefits are code and architecture simplicity as well as respecting k8s standards.
 * Deciders: cloud-on-k8s team
 * Date: 2019-05-28
 

operators/Dockerfile

@@ -15,9 +15,8 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 \
 		go build \
 			-ldflags "$GO_LDFLAGS" -tags="$GO_TAGS" -a \
 			-o elastic-operator github.com/elastic/cloud-on-k8s/operators/cmd
-RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -tags="$GO_TAGS" -a -o process-manager github.com/elastic/cloud-on-k8s/operators/cmd/process-manager
 
-# Copy the controller-manager and the process-manager into a thin image
+# Copy the controller-manager into a thin image
 FROM centos:7
 
 RUN set -x \
@@ -29,6 +28,5 @@ WORKDIR /eck
 USER 101
 
 COPY --from=builder /go/src/github.com/elastic/cloud-on-k8s/operators/elastic-operator .
-COPY --from=builder /go/src/github.com/elastic/cloud-on-k8s/operators/process-manager .
 ENTRYPOINT ["./elastic-operator"]
 CMD ["manager"]

operators/Makefile

@@ -42,7 +42,6 @@ OPERATOR_IMAGE ?= $(IMG):$(VERSION)-$(TAG)
 ifeq ($(SNAPSHOT_RELEASE), false)
 	OPERATOR_IMAGE = $(IMG):$(TAG)
 endif
-OPERATOR_IMAGE_LATEST ?= $(IMG):latest
 
 GO_LDFLAGS := -X github.com/elastic/cloud-on-k8s/operators/pkg/about.version=$(VERSION) \
 	-X github.com/elastic/cloud-on-k8s/operators/pkg/about.buildHash=$(TAG) \
@@ -71,7 +70,7 @@ PSP ?= 0
 ##  --       Development       --  ##
 #####################################
 
-all: dep-vendor-only unit integration e2e-compile check-fmt elastic-operator process-manager check-license-header
+all: dep-vendor-only unit integration e2e-compile check-fmt elastic-operator check-license-header
 
 ## -- build
 
@@ -91,9 +90,6 @@ generate:
 elastic-operator: generate
 	go build -ldflags "$(GO_LDFLAGS)" -tags='$(GO_TAGS)' -o bin/elastic-operator github.com/elastic/cloud-on-k8s/operators/cmd
 
-process-manager:
-	go build  -tags='$(GO_TAGS)' -o bin/process-manager github.com/elastic/cloud-on-k8s/operators/cmd/process-manager
-
 fmt:
 	goimports -w pkg cmd
 
@@ -132,7 +128,7 @@ run: install-crds go-run
 
 go-run:
     # Run the operator locally with role All, with debug logs, operator image set to latest and operator namespace for a global operator
-	AUTO_PORT_FORWARD=true OPERATOR_IMAGE=$(OPERATOR_IMAGE_LATEST) \
+	AUTO_PORT_FORWARD=true \
 		go run \
 			-ldflags "$(GO_LDFLAGS)" \
 			-tags "$(GO_TAGS)" \
@@ -223,7 +219,7 @@ set-context-minikube:
 
 bootstrap-minikube:
 	hack/minikube-cluster.sh
-	$(MAKE) set-context-minikube registry lazy-push-latest-operator-image-in-local-registry cluster-bootstrap
+	$(MAKE) set-context-minikube cluster-bootstrap
 
 ## -- gke
 
@@ -247,29 +243,12 @@ ifeq ($(PSP), 1)
 endif
 ifeq ($(SKIP_DOCKER_COMMAND), false)
 	# push "latest" operator image to be used for init containers when running the operator locally
-	$(MAKE) docker-build docker-push OPERATOR_IMAGE=$(OPERATOR_IMAGE_LATEST)
+	$(MAKE) docker-build docker-push
 endif
 
 delete-gke: require-gcloud-project
 	GKE_CLUSTER_VERSION=$(GKE_CLUSTER_VERSION) ./hack/gke-cluster.sh delete
 
-## -- registry in the cluster
-
-registry:
-	@ echo "-> Deploying registry..."
-	@ hack/registry.sh create
-
-lazy-push-latest-operator-image-in-local-registry:
-	@ hack/registry.sh port-forward start
-	@ docker pull $(OPERATOR_IMAGE_LATEST) || $(MAKE) docker-build docker-push OPERATOR_IMAGE=$(OPERATOR_IMAGE_LATEST)
-	@ hack/registry.sh port-forward stop
-
-force-push-latest-operator-image-in-local-registry:
-	@ hack/registry.sh port-forward start
-	@ $(MAKE) docker-build docker-push OPERATOR_IMAGE=$(OPERATOR_IMAGE_LATEST)
-	@ hack/registry.sh port-forward stop
-
-
 #################################
 ##  --    Docker images    --  ##
 #################################

operators/cmd/manager/main.go

@@ -72,11 +72,6 @@ func init() {
 		"",
 		"namespace in which this operator should manage resources (defaults to all namespaces)",
 	)
-	Cmd.Flags().String(
-		operator.ImageFlag,
-		"",
-		"image containing the binaries for this operator",
-	)
 	Cmd.Flags().Bool(
 		AutoPortForwardFlagName,
 		false,
@@ -183,13 +178,6 @@ func execute() {
 		dialer = portforward.NewForwardingDialer()
 	}
 
-	operatorImage := viper.GetString(operator.ImageFlag)
-	if operatorImage == "" {
-		log.Error(fmt.Errorf("%s is a required flag", operator.ImageFlag),
-			"required configuration missing")
-		os.Exit(1)
-	}
-
 	operatorNamespace := viper.GetString(OperatorNamespaceFlag)
 	if operatorNamespace == "" {
 		log.Error(fmt.Errorf("%s is a required flag", OperatorNamespaceFlag),
@@ -259,7 +247,6 @@ func execute() {
 	log.Info("Setting up controllers", "roles", roles)
 	if err := controller.AddToManager(mgr, roles, operator.Parameters{
 		Dialer:            dialer,
-		OperatorImage:     operatorImage,
 		OperatorNamespace: operatorNamespace,
 		OperatorInfo:      operatorInfo,
 		CACertRotation: certificates.RotationParams{