Do not set initial_master_nodes if cluster has been bootstrapped #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
reviewed
Jul 17, 2019
operators/pkg/controller/elasticsearch/version/version7/initial_master_nodes.go
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // no annotation, let see if the cluster has been bootstrapped by looking at it's UUID | ||
| if clusterState.ClusterState != nil && len(clusterState.ClusterState.ClusterUUID) > 0 { |
There was a problem hiding this comment.
I don't like that isBootstrapped has the side effect of actually storing the cluster UUID on the ES resource.
There was a problem hiding this comment.
Since it is rather small I have inlined the function and make it explicit in the ClusterInitialMasterNodesEnforcer documentation.
pebrc
approved these changes
Jul 18, 2019
thbkrkr
approved these changes
Jul 18, 2019
barkbay
added a commit
to barkbay/cloud-on-k8s
that referenced
this pull request
Jul 18, 2019
…stic#1272) * Do not set initial_master_nodes if cluster has been bootstrapped
barkbay
added a commit
that referenced
this pull request
Jul 18, 2019
* Do not set initial_master_nodes if cluster has been bootstrapped * Backport of #1272
sebgl
added a commit
to sebgl/cloud-on-k8s
that referenced
this pull request
Jul 19, 2019
This is a port of elastic#1272 in the new code structure.
sebgl
added a commit
to sebgl/cloud-on-k8s
that referenced
this pull request
Jul 24, 2019
This is a port of elastic#1272 in the new code structure.
sebgl
added a commit
to sebgl/cloud-on-k8s
that referenced
this pull request
Jul 31, 2019
This is a port of elastic#1272 in the new code structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
initial_master_nodesis not set once the cluster has been bootstrapped.It is a partial fix for #1201