Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure settings finalizer: do not rely on object.GetObjectKind() #1279

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Secure settings finalizer: do not rely on object.GetObjectKind() #1279

merged 2 commits into from
Jul 18, 2019

Conversation

barkbay
Copy link
Contributor

@barkbay barkbay commented Jul 18, 2019

This is an attempt to fix #1275 as it seems that object.GetObjectKind() may return an empty string.

@barkbay
Copy link
Contributor Author

barkbay commented Jul 18, 2019

jenkins test this please

sebgl
sebgl approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting bug!
Should we make those strings constants at the top of the file?

anyasabo
anyasabo approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@anyasabo anyasabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@barkbay barkbay merged commit 76d5360 into elastic:master Jul 18, 2019
@barkbay barkbay mentioned this pull request Jul 18, 2019
Merged
@artemnikitin artemnikitin added v0.9.0 >bug Something isn't working labels Jul 19, 2019
barkbay added a commit that referenced this pull request Jul 19, 2019
@barkbay
Do not rely on getKind() (#1283)
f0a7308 
Backport of #1279 to 0.9
@thbkrkr thbkrkr mentioned this pull request Jul 22, 2019
Merged
@anyasabo anyasabo mentioned this pull request Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyasabo anyasabo anyasabo approved these changes

@sebgl sebgl sebgl approved these changes

@pebrc pebrc pebrc approved these changes

Assignees
No one assigned
Labels
>bug Something isn't working v0.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ES secure settings finalizer hangs
5 participants
@barkbay @pebrc @sebgl @anyasabo @artemnikitin