Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround controller-runtime webhook upsert bug (#1337) #1350

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Workaround controller-runtime webhook upsert bug (#1337) #1350

merged 1 commit into from
Jul 23, 2019

Conversation

pebrc
Copy link
Collaborator

@pebrc pebrc commented Jul 23, 2019

Backport of #1337

@pebrc pebrc added the backport For backport PRs label Jul 23, 2019
@pebrc pebrc requested review from thbkrkr, barkbay and anyasabo July 23, 2019 15:45
@pebrc
Copy link
Collaborator Author

pebrc commented Jul 23, 2019

Jenkins test this please

@pebrc
Copy link
Collaborator Author

pebrc commented Jul 23, 2019 •
edited
Loading

Build keeps failing in build docs stage with

16:18:38  Error executing: /node_modules/parcel/bin/cli.js build resources/web/docs_js/index.js /node_modules -d resources/web -o docs.js 
16:18:38  
16:18:38  ---
16:18:38  Can't exec "/node_modules/parcel/bin/cli.js": No such file or directory at lib/ES/Util.pm line 653.
16:18:39  Makefile:183: recipe for target 'ci-build-docs' failed

cc @artemnikitin

@artemnikitin artemnikitin mentioned this pull request Jul 23, 2019
Merged
@artemnikitin
Copy link
Member

@pebrc PR with fix #1351

@anyasabo
Copy link
Contributor

Jenkins test this please

@pebrc pebrc force-pushed the fix-webhook-upgrade-0.9 branch from cb649c7 to bc0113e Compare July 23, 2019 20:15
@pebrc pebrc merged commit 6fbc2ff into elastic:0.9 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyasabo anyasabo anyasabo approved these changes

@thbkrkr thbkrkr thbkrkr approved these changes

@barkbay barkbay Awaiting requested review from barkbay

Assignees
No one assigned
Labels
backport For backport PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pebrc @artemnikitin @anyasabo @thbkrkr