Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multiple user specified secure settings secrets #1627

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

pebrc
Copy link
Collaborator

@pebrc pebrc commented Aug 25, 2019

Fixes #1457

Allow for multiple user specified secure settings secrets

This changes the API for all three CRDs, Elasticsearch, Kibana and APM Server to
accept multiple secret references instead of just one. This is to facilitate use
cases where users want an easy way to source secure setting from various
locations without aggregating them manually.

Instead the operator aggregates the contents of all specified secrets into one
new secret managed by ECK which will be mounted into the pods and the contents
of which will be loaded into the respective keystores.

Minor Refactorings

  • allow multiple namespaced names in named watches (to facilitate watching multiple user specified secrets)
  • introduced a driver interface to avoid super long argument lists and still allow code reuse between different controllers e.g. for keystore and certificate management (separate commit)

pebrc added 2 commits August 25, 2019 18:33
This changes the API for all three CRDs, Elasticsearch, Kibana and APM Server to
accept multiple secret references instead of just one. This is to facilitate use
cases where users want an easy way to source secure setting from various
locations without aggregating them manually.

Instead the operator aggregates the contents of all specified secrets into one
new secret managed by ECK which will be mounted into the pods and the contents
of which will be loaded into the respective keystores.
@pebrc pebrc added >enhancement Enhancement of existing functionality v1.0.0-beta1 labels Aug 25, 2019
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

//
// Secure settings are provided by the user in the APM or Kibana Spec through a secret reference.
// Secure settings are provided by the user in the resource Spec through secret references.
// The user provicded secrets are then aggregated into a single secret.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: provided

@pebrc pebrc merged commit f7923b1 into elastic:master Aug 26, 2019
@pebrc pebrc added >breaking and removed >enhancement Enhancement of existing functionality labels Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple secure settings secrets
2 participants