Set Elasticsearch Pod default memory limit to 2Gi #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to how we set a default request of 2Gi to prevent the Pod from
being scheduled on a node without at least 2Gi memory, let's set a
default memory request of 2Gi. Which should prevent the Pod from being
the first one evicted on a node running out of memory.
Those defaults can be overridden by the user, or disabled entirely by
providing an empty ({}) memory requests or limits.
No default CPU is set.
sebgl
commented
Sep 27, 2019
| DefaultResources = corev1.ResourceRequirements{ | ||
| Requests: map[corev1.ResourceName]resource.Quantity{ | ||
| corev1.ResourceMemory: resource.MustParse("2Gi"), | ||
| }, | ||
| Limits: map[corev1.ResourceName]resource.Quantity{ | ||
| corev1.ResourceMemory: resource.MustParse("2Gi"), | ||
| }, |
There was a problem hiding this comment.
Technically, we don't have to apply both Requests and Limits: if only Limits are set, Kubernetes defaults to set Requests to the same value.
However I tend to prefer making both clearly explicit here (the comment helps understanding their respective role).
pebrc
approved these changes
Sep 27, 2019
pebrc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how we set a default request of 2Gi to prevent the Pod from
being scheduled on a node without at least 2Gi memory, let's set a
default memory request of 2Gi. Which should prevent the Pod from being
the first one evicted on a node running out of memory.
Those defaults can be overridden by the user, or disabled entirely by
providing an empty (
{}) memory requests or limits.If either limits or requests is provided by the user (or both), we don't
apply our default resources requirements.
No default CPU is set.
Fixes the ES part of #1454.