-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kibana documentation #1874
Add Kibana documentation #1874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very comprehensive. 👍 I have made some suggestions to fix links and change wording to comply with the Elastic style guide.
LGTM, a couple of nits. Another thing I realized we might want to call out is how to connect to an external cluster, e.g. because it's easy to configure it insecurely (for instance, putting the ES password in the Kibana spec rather than a secret), so it would be helpful to give people a clear and secure example |
👍 , and this is what I wanted to do at first when I realized that user must provide a reference to an Elasticsearch cluster. I'm not sure it makes sense to talk about that until #1875 is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, otherwise LGTM.
Fix #1389