Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kibana documentation #1874

Merged
merged 16 commits into from
Oct 10, 2019
Merged

Add Kibana documentation #1874

merged 16 commits into from
Oct 10, 2019

Conversation

barkbay
Copy link
Contributor

@barkbay barkbay commented Oct 4, 2019

Fix #1389

@barkbay barkbay added >docs Documentation v1.0.0-beta1 labels Oct 4, 2019
@barkbay barkbay marked this pull request as ready for review October 4, 2019 09:18
Copy link
Contributor

@charith-elastic charith-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very comprehensive. 👍 I have made some suggestions to fix links and change wording to comply with the Elastic style guide.

docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
@thbkrkr thbkrkr requested a review from alaudazzi October 7, 2019 11:12
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
docs/kibana.asciidoc Outdated Show resolved Hide resolved
@anyasabo
Copy link
Contributor

anyasabo commented Oct 9, 2019

LGTM, a couple of nits. Another thing I realized we might want to call out is how to connect to an external cluster, e.g.
#1875 (comment)

because it's easy to configure it insecurely (for instance, putting the ES password in the Kibana spec rather than a secret), so it would be helpful to give people a clear and secure example

@barkbay
Copy link
Contributor Author

barkbay commented Oct 10, 2019

LGTM, a couple of nits. Another thing I realized we might want to call out is how to connect to an external cluster, e.g.
#1875 (comment)

because it's easy to configure it insecurely (for instance, putting the ES password in the Kibana spec rather than a secret), so it would be helpful to give people a clear and secure example

👍 , and this is what I wanted to do at first when I realized that user must provide a reference to an Elasticsearch cluster. I'm not sure it makes sense to talk about that until #1875 is resolved.

docs/kibana.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, otherwise LGTM.

@barkbay barkbay merged commit 4c07c81 into elastic:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana docs
4 participants