Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename statefulset label name with the "-name" suffix #1913

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Rename statefulset label name with the "-name" suffix #1913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/troubleshooting.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Next, check the Pod status. If a pod fails to reach the `Running` status after a

[source,sh]
----
kubectl get pods -l elasticsearch.k8s.elastic.co/statefulset=elasticsearch-sample-es-default
kubectl get pods -l elasticsearch.k8s.elastic.co/statefulset-name=elasticsearch-sample-es-default

NAME READY STATUS RESTARTS AGE
elasticsearch-sample-es-66sv6dvt7g 0/1 Pending 0 3s
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/elasticsearch/label/label.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ const (
VersionLabelName = "elasticsearch.k8s.elastic.co/version"
// PodNameLabelName used to store the name of the pod on other objects
PodNameLabelName = "elasticsearch.k8s.elastic.co/pod-name"
// StatefulSetNameLabelName used to store the name of the statefulset
StatefulSetNameLabelName = "elasticsearch.k8s.elastic.co/statefulset"
// StatefulSetNameLabelName used to store the name of the statefulset.
StatefulSetNameLabelName = "elasticsearch.k8s.elastic.co/statefulset-name"
// VolumeNameLabelName is the name of the volume e.g. elasticsearch-data a PVC was used for.
VolumeNameLabelName = "elasticsearch.k8s.elastic.co/volume-name"
// ConfigChecksumLabelName used to store the checksum of the Elasticsearch configuration
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/elasticsearch/nodespec/podspec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func TestBuildPodTemplateSpec(t *testing.T) {
"elasticsearch.k8s.elastic.co/node-ingest": "true",
"elasticsearch.k8s.elastic.co/node-master": "true",
"elasticsearch.k8s.elastic.co/node-ml": "true",
"elasticsearch.k8s.elastic.co/statefulset": "name-es-nodeset-1",
"elasticsearch.k8s.elastic.co/statefulset-name": "name-es-nodeset-1",
"elasticsearch.k8s.elastic.co/version": "7.2.0",
"pod-template-label-name": "pod-template-label-value",
},
Expand Down