Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use discovery.seed_providers instead of discovery.zen.hosts_provider starting 7.x #2029

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

sebgl
Copy link
Contributor

@sebgl sebgl commented Oct 21, 2019

Starting Elasticsearch 7.0, discovery.zen.hosts_provider is deprecated
in favor of discovery.seed_providers.
The setting is removed in 8.0, preventing any 8.0 cluster to bootstrap.

This commit switches over the Elasticsearch version when building the
elasticsearch.yml configuration, to make sure versions lower than 7.0
use discovery.zen.hosts_provider, and other versions use the newer
discovery.seed_providers.

I did some manual testing, also covered by E2E tests:

  • bootstrap a 6.8.0 cluster
  • bootstrap a 7.2.0 cluster
  • mutate a 6.8.0 cluster to 7.2.0

Starting Elasticsearch 7.0, `discovery.zen.hosts_provider` is deprecated
in favor of `discovery.seed_providers`.
The setting is removed in 8.0, preventing any 8.0 cluster to bootstrap.

This commit switches over the Elasticsearch version when building the
elasticsearch.yml configuration, to make sure versions lower than 7.0
use `discovery.zen.hosts_provider`, and other versions use the newer
`discovery.seed_providers`.
@sebgl sebgl added >bug Something isn't working v1.0.0 labels Oct 21, 2019
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants