Check resource version when deleting a Pod during force-upgrades #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an additional precondition when we delete a Pod during a force-upgrade: we require the Pod version in the apiserver to be the same as the cached Pod version we want to delete. This helps avoiding situations were we would, for example, delete a Pending pod that is actually not Pending anymore.
thbkrkr
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an additional precondition when we delete a Pod during
a force-upgrade: we require the Pod version in the apiserver to be the
same as the cached Pod version we want to delete.
This helps avoiding situations were we would, for example, delete a
Pending pod that is actually not Pending anymore.
Fixes #1916.