Reconcile all clusters on license change #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License changes now propagate almost immediately to all clusters. E2e test has been ajusted (and shortened) as a result of that.
david-kow
approved these changes
Nov 21, 2019
| // list all cluster licenses referencing the given enterprise license | ||
| matchLabels := license.NewLicenseByNameSelector(licenseName) | ||
| err := c.List(&list, matchLabels) | ||
| func reconcileRequestsForAllClusters(c k8s.Client) ([]reconcile.Request, error) { |
There was a problem hiding this comment.
nit: this name indicates (to me) that something will be reconciled here
There was a problem hiding this comment.
It's meant to be read as a noun not as a verb :-)
anyasabo
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2131