Report total memory under management for licensing #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start a reporter in a goroutine that repeatedly aggregates the total memory of all Elastic components and reports it in the form of a licensing information in a config map.
pebrc
previously requested changes
Dec 17, 2019
thbkrkr
force-pushed
the
memory-accounting-for-licensing
branch
from
9f59f72
to
562d835
Compare
david-kow
reviewed
Dec 17, 2019
pebrc
dismissed
their stale review
Issue has been fixed, dismissing this big red X as I am off tomorrow for most of the day.
sebgl
reviewed
Dec 17, 2019
thbkrkr
force-pushed
the
memory-accounting-for-licensing
branch
from
692cb4e
to
f8b86bf
Compare
anyasabo
reviewed
Dec 17, 2019
anyasabo
reviewed
Dec 17, 2019
anyasabo
reviewed
Dec 17, 2019
anyasabo
reviewed
Dec 17, 2019
This comment has been minimized.
This comment has been minimized.
anyasabo
reviewed
Dec 17, 2019
anyasabo
reviewed
Dec 17, 2019
anyasabo
reviewed
Dec 17, 2019
david-kow
reviewed
Dec 17, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks for all the feedbacks. |
anyasabo
reviewed
Dec 18, 2019
sebgl
reviewed
Dec 19, 2019
|
|
||
| log.V(1).Info("Saving", "license_info", info) | ||
| cm := corev1.ConfigMap{ | ||
| ObjectMeta: metav1.ObjectMeta{ |
There was a problem hiding this comment.
We'd also need to retrieve StatefulSets in the operator namespace so we get its UID, which is not something we currently have RBAC permissions for.
david-kow
reviewed
Dec 19, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sebgl
reviewed
Dec 20, 2019
sebgl
approved these changes
Dec 20, 2019
mjmbischoff
pushed a commit
to mjmbischoff/cloud-on-k8s
that referenced
this pull request
Jan 13, 2020
Start a reporter in a goroutine that repeatedly (every 2 minutes) aggregates the total memory of
all Elastic managed components by the operator and reports it in the form of a licensing information in a config map.
Example of the content of the config map:
> kubectl -n elastic-system get cm elastic-licensing -o json | jq .data
{
"eck_license_level": "enterprise",
"enterprise_resource_units": "1",
"timestamp": "2019-12-20T18:18:31+01:00",
"total_managed_memory": "12.88GB"
}
Notes:
- "Enterprise resource units" is an Elastic unit calculated with the total memory under management divided by 64GB.
- The ECK license level can be basic, trial-enterprise or entreprise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start a reporter in a goroutine that repeatedly (every 2 minutes) aggregates the total memory of
all Elastic managed components by the operator and reports it in the form of a licensing information
in a config map.
I left
cmd/licensing-info/main.goto show another use: