Rename log.logger to event.dataset as recommended in ECS #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
previously approved these changes
Feb 7, 2020
|
I'm a little confused by the amount of fields that can be used to describe the source of events and when one should be used more than another (elastic/ecs#281 (comment)). But this change doesn't look dangerous. I admit that I trust you on this one with slightly closed eyes. How is it ok to not set |
|
I have second thoughts now that I see that ECS seems to revise its position on where to put the logger in the discussion you linked to @thbkrkr |
|
I didn't set this field for this reason and created an issue to discuss improvements re. ECS : #2467 (comment) |
|
Let's not do this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
we get
in Kibanas log UI by following the ECS recommendation for
event.dataset