Always include operator namespace in cached k8s client namespaces #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pebrc
changed the title
|
I was wondering if we needed to update https://github.com/elastic/cloud-on-k8s/blob/master/docs/operator-config.asciidoc indicating that no matter what, the operator always needs to be monitoring its own namespace. After thinking about it though I don't think this will be surprising to people, even if they do not know about the licensing configmap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trial license e2e test was failing since #2530 because we are now running the e2e with a operator restricted to the managed namespaces via
--namespaces, but we did not include the operator namespace itself in the list of namespaces.As the list of namespaces controls which resources will be cached by the k8s client the operator was not able to access the license related secrets in the operator namespace and trial mode could not be activated.
This PR makes sure the operator namespace is always included in the client cache even when running in namespace restricted mode.