Do not call the voting config exclusions API at every single reconciliation #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets up an annotation containing the last applied value for voting config exclusions. The annotation can either be: - nil: it has not been set yet - empty: the last setting applied was to reset voting config exclusions - not empty: it contains the last applied voting config exclusions Before making the ES API call, which check the value of that annotation. Users can remove the annotation at anytime, it will be set again after the next API call. Note we ignore cases where users would manipulate voting config exclusions behind our back here.
pebrc
reviewed
Mar 2, 2020
sebgl
commented
Mar 2, 2020
| copy(sliceCopy, excludedNodes) | ||
| sort.Strings(sliceCopy) | ||
| return strings.Join(sliceCopy, ",") | ||
| } |
There was a problem hiding this comment.
I decided to sort a copy of the slice instead of mutating the slice itself. That's an extra allocation but I would not expect such a side effect to occur in that function.
anyasabo
changed the title
pebrc
added
>non-issue
and removed
>enhancement
|
reverted in #2880 (thus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up an annotation containing the last applied value for
voting config exclusions. The annotation can either be:
Before making the ES API call to either add nodes to voting config exclusions
or reset its value, we check the value of the annotation.
Users can remove the annotation at anytime, it will be set again after
the next API call.
Note we ignore cases where users would manipulate voting config
exclusions behind our back here.
Fixes #2605.