Update transport cert verification to full #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
approved these changes
Mar 5, 2020
This was referenced Apr 6, 2020
pebrc
added
>non-issue
and removed
>enhancement
|
Reverted in #2831 (thus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use full certificate verification for the transport layer since users cannot modify the transport certs, and we issue certificates for each pod. We do not have any open issues to allow users to modify the transport certs, and if we decide to change course later we can roll back this change pretty easily.
Also clarifies why we use our own cert validation for the ES HTTP client, since we do not need it when we manage certificates and it was confusing for me until dear @nkvoll pointed it out.