Close idle connections on the http client directly #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized while refactoring this piece of code for being used by another controller that we don't need to keep track of the http.Transport, since calling Close() on the client propagates the close to the underlying transport directly. This simplifies the ES client structure a little bit, and will be useful for the refactoring I'm working on.
pebrc
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized while refactoring this piece of code for being used by
another controller that we don't need to keep track of the
http.Transport, since calling Close() on the client propagates
to the underlying transport directly.
This simplifies the ES client structure a little bit, and will be useful
for the refactoring I'm working on.
To make sure this still works as expected, I tested the goroutine leaks using
the methodology outlined in this comment. Closing the client has the same effect
as closing the underlying transport.