Do not reject PVC update when a different unit is used #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we apply a manifest with a 1024Gi storage requirement, it may be internally persisted with a different storage unit (eg. 1Ti). When doing a strict deep equal comparison, 1Ti and 1024Gi are different. A user applying such a manifest will not have any update allowed, even though he keeps using 1024Gi. This fixes it by relying on `apiequality.Semantic.DeepEqual`, which is used in Kubernetes itself: https://github.com/kubernetes/kubernetes/blob/c369cf187ea765c0a2387f2b39abe6ed18c8e6a8/pkg/apis/apps/validation/validation.go#L156
|
I'd like to include this fix in the 1.1 release. |
pebrc
approved these changes
Apr 10, 2020
sebgl
added a commit
to sebgl/cloud-on-k8s
that referenced
this pull request
Apr 10, 2020
When we apply a manifest with a 1024Gi storage requirement, it may be internally persisted with a different storage unit (eg. 1Ti). When doing a strict deep equal comparison, 1Ti and 1024Gi are different. A user applying such a manifest will not have any update allowed, even though he keeps using 1024Gi. This fixes it by relying on `apiequality.Semantic.DeepEqual`, which is used in Kubernetes itself: https://github.com/kubernetes/kubernetes/blob/c369cf187ea765c0a2387f2b39abe6ed18c8e6a8/pkg/apis/apps/validation/validation.go#L156
sebgl
added a commit
that referenced
this pull request
Apr 10, 2020
When we apply a manifest with a 1024Gi storage requirement, it may be internally persisted with a different storage unit (eg. 1Ti). When doing a strict deep equal comparison, 1Ti and 1024Gi are different. A user applying such a manifest will not have any update allowed, even though he keeps using 1024Gi. This fixes it by relying on `apiequality.Semantic.DeepEqual`, which is used in Kubernetes itself: https://github.com/kubernetes/kubernetes/blob/c369cf187ea765c0a2387f2b39abe6ed18c8e6a8/pkg/apis/apps/validation/validation.go#L156
anyasabo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2856.
When we apply a manifest with a 1024Gi storage requirement, it may be
internally persisted with a different storage unit (eg. 1Ti). When doing
a strict deep equal comparison, 1Ti and 1024Gi are different.
A user applying such a manifest will not have any update allowed, even
though he keeps using 1024Gi.
This fixes it by relying on
apiequality.Semantic.DeepEqual, which isused in Kubernetes itself:
https://github.com/kubernetes/kubernetes/blob/c369cf187ea765c0a2387f2b39abe6ed18c8e6a8/pkg/apis/apps/validation/validation.go#L156