Do not manage keystore if already initialized #3295
Conversation
anyasabo
changed the title
| @@ -101,6 +101,13 @@ func TestResources(t *testing.T) { | |||
|
|
|||
| set -eux | |||
|
|
|||
| keystore_initialized_flag=/bar/data/elastic-internal-init-keystore.ok | |||
There was a problem hiding this comment.
This isn't necessarily your change but it seems odd we're not reusing the script constant here
| @@ -61,7 +61,7 @@ func initContainerParameters(typ string) keystore.InitContainerParameters { | |||
| KeystoreCreateCommand: fmt.Sprintf("%s keystore create --force", typ), | |||
| KeystoreAddCommand: fmt.Sprintf(`cat "$filename" | %s keystore add "$key" --stdin --force`, typ), | |||
| SecureSettingsVolumeMountPath: keystore.SecureSettingsVolumeMountPath, | |||
| DataVolumePath: fmt.Sprintf(DataPathTemplate, typ), | |||
| KeystoreVolumePath: fmt.Sprintf(DataPathTemplate, typ), | |||
There was a problem hiding this comment.
Also not your change, but typ is a typo of type, correct?
There was a problem hiding this comment.
type is a reserved word though, that's probably why it's typ.
There was a problem hiding this comment.
typ is acceptable even I'm agree it's disturbing at the first glance. Alternative ideas: kind, beatType, specType, beatSpecType.
We would also need to raise some issues for all the other stack components to ensure that there is a consistent behaviour across the stack. I agree that it would be nice, but I'm not sure we want to coordinate this effort. |
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Fix #3294 by creating a file to record if the keystore has been initialized.