Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init containers image defaulting #3525

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Jul 23, 2020

This commit makes sure that user provided init containers inherit from the default values including the main container image.

I refactored a bit the functions that build the PodTemplateSpec to try to make them boring and always have the same pattern by preparing the volumes, volumeMounts, initContainers and then only call:

		WithVolumes(volumes...).
		WithVolumeMounts(volumeMounts...).
		WithInitContainers(initContainers...).
		WithInitContainerDefaults()

Resolves #3453.

@thbkrkr thbkrkr added >bug Something isn't working v1.3.0 labels Jul 23, 2020
@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jul 23, 2020

jenkins test this please

Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr thbkrkr merged commit 1bcdc14 into elastic:master Jul 29, 2020
@thbkrkr thbkrkr deleted the init-containers-image-defaulting branch July 30, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working v1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InitContainer image defaulting is not consistent
2 participants